clang-tidy fixes

sailfish/src/cacheserver.cpp

@@ -31,7 +31,7 @@
 #include "utils.h"
 
 FilteringWorker::FilteringWorker(QObject *parent) :
-    QThread(parent), error(false)
+    QThread(parent)
 {
 }
 
@@ -392,7 +392,7 @@ QString CacheServer::getFileUrl(const QString &id)
 
     QString filename;
     if (item.id.isEmpty()) {
-        item = db->readCacheByFinalUrl(id);
+        //item = db->readCacheByFinalUrl(id);
         filename = id;
     } else {
         filename = item.finalUrl;

sailfish/src/cacheserver.h

@@ -37,11 +37,11 @@ class FilteringWorker : public QThread
 {
     Q_OBJECT
 public:
-    explicit FilteringWorker(QObject *parent = 0);
+    explicit FilteringWorker(QObject *parent = nullptr);
-    QHttpResponse *resp;
+    QHttpResponse *resp = nullptr;
-    QHttpRequest *req;
+    QHttpRequest *req = nullptr;
     QByteArray data;
-    bool error;
+    bool error = false;
 
 protected:
     void run();

sailfish/src/customnetworkaccessmanager.cpp

@@ -2,7 +2,7 @@
 #include <QNetworkReply>
 #include <QDebug>
 
-CustomNetworkAccessManager::CustomNetworkAccessManager(QString userAgent, QObject *parent) :
+CustomNetworkAccessManager::CustomNetworkAccessManager(const QString &userAgent, QObject *parent) :
     QNetworkAccessManager(parent), userAgent(userAgent)
 {
     this->setNetworkAccessible(QNetworkAccessManager::Accessible);

sailfish/src/customnetworkaccessmanager.h

@@ -9,7 +9,7 @@ class CustomNetworkAccessManager: public QNetworkAccessManager
 {
 
 public:
-    CustomNetworkAccessManager(QString userAgent, QObject *parent = 0);
+    explicit CustomNetworkAccessManager(const QString &userAgent, QObject *parent = 0);
     QNetworkReply *createRequest(Operation operation, const QNetworkRequest &reqest, QIODevice *outgoingData);
 
 private:

sailfish/src/databasemanager.h

@@ -51,7 +51,7 @@ public:
         QString streamId;
         QString moduleId;
         QString tabId;
-        int date;
+        int date = 0;
     };
 
     struct Dashboard {
@@ -88,13 +88,13 @@ public:
         QString query;
         QString icon;
         QString type;
-        int unread;
+        int unread = 0;
-        int read;
+        int read = 0;
-        int saved;
+        int saved = 0;
-        int slow;
+        int slow = 0;
-        int newestItemAddedAt;
+        int newestItemAddedAt = 0;
-        int updateAt;
+        int updateAt = 0;
-        int lastUpdate;
+        int lastUpdate = 0;
     };
 
     struct Entry {
@@ -109,17 +109,17 @@ public:
         QString feedIcon;
         QString feedTitle;
         QString annotations;
-        int fresh;
+        int fresh = 0;
-        int freshOR;
+        int freshOR = 0;
-        int read;
+        int read = 0;
-        int saved;
+        int saved = 0;
-        int liked;
+        int liked = 0;
-        int cached;
+        int cached = 0;
-        int broadcast;
+        int broadcast = 0;
-        int publishedAt;
+        int publishedAt = 0;
-        int createdAt;
+        int createdAt = 0;
-        int crawlTime;
+        int crawlTime = 0;
-        int timestamp;
+        int timestamp = 0;
     };
 
     struct CacheItem {
@@ -132,8 +132,8 @@ public:
         QString contentType;
         QString entryId;
         QString streamId;
-        int date;
+        int date = 0;
-        int flag;
+        int flag = 0;
     };
 
     enum ActionsTypes {
@@ -165,9 +165,9 @@ public:
         QString id2;
         QString id3;
         QString text;
-        int date1;
+        int date1 = 0;
-        int date2;
+        int date2 = 0;
-        int date3;
+        int date3 = 0;
     };
 
     static DatabaseManager* instance(QObject *parent = nullptr);

sailfish/src/entrymodel.h

@@ -43,7 +43,7 @@ public:
 
 private:
     QString feedId;
-    EntryModel *model;
+    EntryModel *model = nullptr;
     void run();
 };
 

sailfish/src/networkaccessmanagerfactory.cpp

@@ -3,14 +3,14 @@
 
 #if QT_VERSION >= QT_VERSION_CHECK(5,0,0) // QT5
 
-NetworkAccessManagerFactory::NetworkAccessManagerFactory(QString userAgent) : QQmlNetworkAccessManagerFactory(),
+NetworkAccessManagerFactory::NetworkAccessManagerFactory(const QString &userAgent) : QQmlNetworkAccessManagerFactory(),
     userAgent(userAgent)
 {
 }
 
 #else // QT5
 
-NetworkAccessManagerFactory::NetworkAccessManagerFactory(QString userAgent) : QDeclarativeNetworkAccessManagerFactory(),
+NetworkAccessManagerFactory::NetworkAccessManagerFactory(const QString &userAgent) : QDeclarativeNetworkAccessManagerFactory(),
     userAgent(userAgent)
 {
 }

sailfish/src/networkaccessmanagerfactory.h

@@ -17,7 +17,7 @@ class NetworkAccessManagerFactory: public QDeclarativeNetworkAccessManagerFactor
 #endif // QT5
 
 public:
-    NetworkAccessManagerFactory(QString userAgent);
+    explicit NetworkAccessManagerFactory(const QString &userAgent);
     virtual QNetworkAccessManager *create(QObject* parent);
 
 private:

sailfish/src/nvfetcher.h

@@ -80,7 +80,7 @@ private:
     QList<DatabaseManager::StreamModuleTab> streamList;
     QList<DatabaseManager::StreamModuleTab> streamUpdateList;
     QList<DatabaseManager::StreamModuleTab> storedStreamList;
-    int publishedBeforeDate;
+    int publishedBeforeDate = 0;
 
     void signIn();
     void startFetching();

sailfish/src/oldreaderfetcher.h

@@ -79,8 +79,8 @@ private:
     //QList<DatabaseManager::StreamModuleTab> storedFeedList;
 
     QString lastContinuation;
-    int continuationCount;
+    int continuationCount = 0;
-    int lastDate;
+    int lastDate = 0;
 
     void signIn();
     void startFetching();