diff --git a/sailfish/src/cacheserver.cpp b/sailfish/src/cacheserver.cpp index 6ec41b1..f84ba40 100644 --- a/sailfish/src/cacheserver.cpp +++ b/sailfish/src/cacheserver.cpp @@ -31,7 +31,7 @@ #include "utils.h" FilteringWorker::FilteringWorker(QObject *parent) : - QThread(parent), error(false) + QThread(parent) { } @@ -392,7 +392,7 @@ QString CacheServer::getFileUrl(const QString &id) QString filename; if (item.id.isEmpty()) { - item = db->readCacheByFinalUrl(id); + //item = db->readCacheByFinalUrl(id); filename = id; } else { filename = item.finalUrl; diff --git a/sailfish/src/cacheserver.h b/sailfish/src/cacheserver.h index d1ef8aa..abce88c 100644 --- a/sailfish/src/cacheserver.h +++ b/sailfish/src/cacheserver.h @@ -37,11 +37,11 @@ class FilteringWorker : public QThread { Q_OBJECT public: - explicit FilteringWorker(QObject *parent = 0); - QHttpResponse *resp; - QHttpRequest *req; + explicit FilteringWorker(QObject *parent = nullptr); + QHttpResponse *resp = nullptr; + QHttpRequest *req = nullptr; QByteArray data; - bool error; + bool error = false; protected: void run(); diff --git a/sailfish/src/customnetworkaccessmanager.cpp b/sailfish/src/customnetworkaccessmanager.cpp index 4934e8f..5884408 100644 --- a/sailfish/src/customnetworkaccessmanager.cpp +++ b/sailfish/src/customnetworkaccessmanager.cpp @@ -2,7 +2,7 @@ #include #include -CustomNetworkAccessManager::CustomNetworkAccessManager(QString userAgent, QObject *parent) : +CustomNetworkAccessManager::CustomNetworkAccessManager(const QString &userAgent, QObject *parent) : QNetworkAccessManager(parent), userAgent(userAgent) { this->setNetworkAccessible(QNetworkAccessManager::Accessible); diff --git a/sailfish/src/customnetworkaccessmanager.h b/sailfish/src/customnetworkaccessmanager.h index ca5ea92..c2b2bcc 100644 --- a/sailfish/src/customnetworkaccessmanager.h +++ b/sailfish/src/customnetworkaccessmanager.h @@ -9,7 +9,7 @@ class CustomNetworkAccessManager: public QNetworkAccessManager { public: - CustomNetworkAccessManager(QString userAgent, QObject *parent = 0); + explicit CustomNetworkAccessManager(const QString &userAgent, QObject *parent = 0); QNetworkReply *createRequest(Operation operation, const QNetworkRequest &reqest, QIODevice *outgoingData); private: diff --git a/sailfish/src/databasemanager.h b/sailfish/src/databasemanager.h index 5a68d7b..3c8cf68 100644 --- a/sailfish/src/databasemanager.h +++ b/sailfish/src/databasemanager.h @@ -51,7 +51,7 @@ public: QString streamId; QString moduleId; QString tabId; - int date; + int date = 0; }; struct Dashboard { @@ -88,13 +88,13 @@ public: QString query; QString icon; QString type; - int unread; - int read; - int saved; - int slow; - int newestItemAddedAt; - int updateAt; - int lastUpdate; + int unread = 0; + int read = 0; + int saved = 0; + int slow = 0; + int newestItemAddedAt = 0; + int updateAt = 0; + int lastUpdate = 0; }; struct Entry { @@ -109,17 +109,17 @@ public: QString feedIcon; QString feedTitle; QString annotations; - int fresh; - int freshOR; - int read; - int saved; - int liked; - int cached; - int broadcast; - int publishedAt; - int createdAt; - int crawlTime; - int timestamp; + int fresh = 0; + int freshOR = 0; + int read = 0; + int saved = 0; + int liked = 0; + int cached = 0; + int broadcast = 0; + int publishedAt = 0; + int createdAt = 0; + int crawlTime = 0; + int timestamp = 0; }; struct CacheItem { @@ -132,8 +132,8 @@ public: QString contentType; QString entryId; QString streamId; - int date; - int flag; + int date = 0; + int flag = 0; }; enum ActionsTypes { @@ -165,9 +165,9 @@ public: QString id2; QString id3; QString text; - int date1; - int date2; - int date3; + int date1 = 0; + int date2 = 0; + int date3 = 0; }; static DatabaseManager* instance(QObject *parent = nullptr); diff --git a/sailfish/src/entrymodel.h b/sailfish/src/entrymodel.h index 4b72c41..0077afc 100644 --- a/sailfish/src/entrymodel.h +++ b/sailfish/src/entrymodel.h @@ -43,7 +43,7 @@ public: private: QString feedId; - EntryModel *model; + EntryModel *model = nullptr; void run(); }; diff --git a/sailfish/src/networkaccessmanagerfactory.cpp b/sailfish/src/networkaccessmanagerfactory.cpp index a2d9def..95e6631 100644 --- a/sailfish/src/networkaccessmanagerfactory.cpp +++ b/sailfish/src/networkaccessmanagerfactory.cpp @@ -3,14 +3,14 @@ #if QT_VERSION >= QT_VERSION_CHECK(5,0,0) // QT5 -NetworkAccessManagerFactory::NetworkAccessManagerFactory(QString userAgent) : QQmlNetworkAccessManagerFactory(), +NetworkAccessManagerFactory::NetworkAccessManagerFactory(const QString &userAgent) : QQmlNetworkAccessManagerFactory(), userAgent(userAgent) { } #else // QT5 -NetworkAccessManagerFactory::NetworkAccessManagerFactory(QString userAgent) : QDeclarativeNetworkAccessManagerFactory(), +NetworkAccessManagerFactory::NetworkAccessManagerFactory(const QString &userAgent) : QDeclarativeNetworkAccessManagerFactory(), userAgent(userAgent) { } diff --git a/sailfish/src/networkaccessmanagerfactory.h b/sailfish/src/networkaccessmanagerfactory.h index 6c35ea1..96aa12a 100644 --- a/sailfish/src/networkaccessmanagerfactory.h +++ b/sailfish/src/networkaccessmanagerfactory.h @@ -17,7 +17,7 @@ class NetworkAccessManagerFactory: public QDeclarativeNetworkAccessManagerFactor #endif // QT5 public: - NetworkAccessManagerFactory(QString userAgent); + explicit NetworkAccessManagerFactory(const QString &userAgent); virtual QNetworkAccessManager *create(QObject* parent); private: diff --git a/sailfish/src/nvfetcher.h b/sailfish/src/nvfetcher.h index 4782792..b4ed188 100644 --- a/sailfish/src/nvfetcher.h +++ b/sailfish/src/nvfetcher.h @@ -80,7 +80,7 @@ private: QList streamList; QList streamUpdateList; QList storedStreamList; - int publishedBeforeDate; + int publishedBeforeDate = 0; void signIn(); void startFetching(); diff --git a/sailfish/src/oldreaderfetcher.h b/sailfish/src/oldreaderfetcher.h index 12735ab..2276a85 100644 --- a/sailfish/src/oldreaderfetcher.h +++ b/sailfish/src/oldreaderfetcher.h @@ -79,8 +79,8 @@ private: //QList storedFeedList; QString lastContinuation; - int continuationCount; - int lastDate; + int continuationCount = 0; + int lastDate = 0; void signIn(); void startFetching();