sfos/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

decode-time: allow bignum years

Browse source 
* src/timefns.c (TM_YEAR_BASE):
Now a constant as it need not be a macro.
(Fdecode_time): Do not signal an overflow merely because the
Gregorian year number does not fix in a fixnum (which can
happen on hosts with 64-bit time_t and with 32-bit int and
EMACS_INT).
This commit is contained in:
Paul Eggert 2019-01-01 11:33:10 -08:00
parent 355b1c3cb9
commit 227343947f
1 changed files with 18 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/timefns.c
View file

@ -44,7 +44,7 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. */
# define HAVE_TZALLOC_BUG false
#endif
#define TM_YEAR_BASE 1900
enum { TM_YEAR_BASE = 1900 };
#ifndef HAVE_TM_GMTOFF
# define HAVE_TM_GMTOFF false
@ -1336,12 +1336,22 @@ usage: (decode-time &optional TIME ZONE) */)
if (!tm)
time_error (localtime_errno);
if (! (MOST_NEGATIVE_FIXNUM - TM_YEAR_BASE <= local_tm.tm_year
&& local_tm.tm_year <= MOST_POSITIVE_FIXNUM - TM_YEAR_BASE))
time_overflow ();
/* Avoid overflow when INT_MAX < EMACS_INT_MAX. */
EMACS_INT tm_year_base = TM_YEAR_BASE;
Lisp_Object year;
if (FASTER_TIMEFNS
&& MOST_NEGATIVE_FIXNUM - TM_YEAR_BASE <= local_tm.tm_year
&& local_tm.tm_year <= MOST_POSITIVE_FIXNUM - TM_YEAR_BASE)
{
/* Avoid overflow when INT_MAX - TM_YEAR_BASE < local_tm.tm_year. */
EMACS_INT tm_year_base = TM_YEAR_BASE;
year = make_fixnum (local_tm.tm_year + tm_year_base);
}
else
{
mpz_set_si (mpz[0], local_tm.tm_year);
mpz_add_ui (mpz[0], mpz[0], TM_YEAR_BASE);
year = make_integer_mpz ();
}
return CALLN (Flist,
make_fixnum (local_tm.tm_sec),
@ -1349,7 +1359,7 @@ usage: (decode-time &optional TIME ZONE) */)
make_fixnum (local_tm.tm_hour),
make_fixnum (local_tm.tm_mday),
make_fixnum (local_tm.tm_mon + 1),
make_fixnum (local_tm.tm_year + tm_year_base),
year,
make_fixnum (local_tm.tm_wday),
(local_tm.tm_isdst < 0 ? make_fixnum (-1)
: local_tm.tm_isdst == 0 ? Qnil : Qt),
@ -1360,7 +1370,7 @@ usage: (decode-time &optional TIME ZONE) */)
: Qnil));
}
/* Return OBJ - OFFSET, checking that OBJ is a valid fixnum and that
/* Return OBJ - OFFSET, checking that OBJ is a valid integer and that
the result is representable as an int. 0 <= OFFSET <= TM_YEAR_BASE. */
static int
check_tm_member (Lisp_Object obj, int offset)