sfos/ecl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

spawn-subprocess: remove pipe synchronization

Browse source
This commit is contained in:
Daniel Kochmanski 2017-05-12 22:19:25 +02:00
parent 1d8f4ff101
commit f4e25c7055
1 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/c/unixsys.d
View file

@ -470,7 +470,6 @@ si_spawn_subprocess(cl_object command, cl_object argv, cl_object environ,
#elif !defined(NACL) /* All POSIX but NaCL/pNaCL */ #elif !defined(NACL) /* All POSIX but NaCL/pNaCL */
{ {
int child_stdin, child_stdout, child_stderr; int child_stdin, child_stdout, child_stderr;
int pipe_fd[2];
argv = ecl_nconc(argv, ecl_list1(ECL_NIL)); argv = ecl_nconc(argv, ecl_list1(ECL_NIL));
argv = _ecl_funcall3(@'coerce', argv, @'vector'); argv = _ecl_funcall3(@'coerce', argv, @'vector');
@ -483,22 +482,11 @@ si_spawn_subprocess(cl_object command, cl_object argv, cl_object environ,
else else
create_descriptor(error, @':output', &child_stderr, &parent_error); create_descriptor(error, @':output', &child_stderr, &parent_error);
pipe(pipe_fd);
child_pid = fork(); child_pid = fork();
if (child_pid == 0) { if (child_pid == 0) {
/* Child */ /* Child */
int j; int j;
void **argv_ptr = (void **)argv->vector.self.t; void **argv_ptr = (void **)argv->vector.self.t;
{
/* Wait for the parent to set up its process structure */
char sync[1];
close(pipe_fd[1]);
while (read(pipe_fd[0], sync, 1) < 1) {
printf("\nError reading child pipe %d", errno);
fflush(stdout);
}
close(pipe_fd[0]);
}
dup2(child_stdin, STDIN_FILENO); dup2(child_stdin, STDIN_FILENO);
if (parent_write) close(parent_write); if (parent_write) close(parent_write);
dup2(child_stdout, STDOUT_FILENO); dup2(child_stdout, STDOUT_FILENO);
@ -529,17 +517,6 @@ si_spawn_subprocess(cl_object command, cl_object argv, cl_object environ,
} else { } else {
pid = ecl_make_fixnum(child_pid); pid = ecl_make_fixnum(child_pid);
} }
{
/* This guarantees that the child process does not exit before
* we have created the process structure. */
char sync[1];
close(pipe_fd[0]);
while (write(pipe_fd[1], sync, 1) < 1) {
printf("\nError writing child pipe %d", errno);
fflush(stdout);
}
close(pipe_fd[1]);
}
close(child_stdin); close(child_stdin);
close(child_stdout); close(child_stdout);
close(child_stderr); close(child_stderr);